Add a NoSecurityHash class for fast testing#20
Open
regularfry wants to merge 1 commit into
Open
Conversation
regularfry
commented
Apr 21, 2023
| p=6, | ||
| maxmem=2**26, | ||
| ).hex() | ||
| if getenv("STUPIDLY_HOBBLE_SECURITY") == "I_AM_AN_IDIOT_YES_I_REALLY_MEAN_IT": |
Contributor
Author
There was a problem hiding this comment.
Feels bad to be doing an env var check here; where should this be?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is controversial, I know, but I think it's worthwhile.
With this patch applied, run the tests like so:
That should be obvious enough that nobody's going to do it by accident. One thing I'm not sure about is if there's a better place to put the
NoSecurityHashclass so that it can be passed in to theCareRecipientForm, so that we could only have the thing that breaks the security where the tests are, not in code that gets loaded at runtime.